Hi Brett,

Thanks. I'd like to contribute some refactorings I made to AbstractWixMojo,
CandleMojo and LightMojo to remove some duplication. Should I file a JIRA
issue and attach a patch like I did with NPANDAY-510?

Adrián

2012/1/5 Brett Porter <br...@apache.org>

> Hi Adrián,
>
> Sorry for the delay... I applied your patch. Since it was helpful in my
> env., I made a few enhancements based on the comments in the issue (set a
> default from the environment, and dealt with spaces in the wixHome
> variable). Do those work for you?
>
> We'd be very happy if you're interested in contributing on a regular
> basis. Are there other aspects that interest you, or do you need any
> pointers?
>
> Regards,
> Brett
>
> On 23/12/2011, at 1:53 AM, Adrián Boimvaser wrote:
>
> > Hi Lars?
> >
> > What's next? Sit and wait?
> > I made some refactorings and improvements to wix-maven plugin I would
> also
> > like to contribute.
> > Is there a way I can become a NPanday developer?
> >
> > Thanks.
> > Adrián.
> >
> > 2011/12/21 Adrián Boimvaser <adrianboimva...@gmail.com>
> >
> >> Thanks Lars,
> >>
> >> I created the issue and attached the patch.
> >>
> >> https://issues.apache.org/jira/browse/NPANDAY-510
> >>
> >> Adrián.
> >>
> >> 2011/12/21 Lars Corneliussen <m...@lcorneliussen.de>
> >>
> >>> Hi Adrián,
> >>>
> >>> happy to hear that.
> >>> The best is, if you create an issue and attach the patch here:
> >>>
> >>>
> https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create
> >>>
> >>> Is that ok for you?
> >>> _
> >>> Lars
> >>>
> >>> Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser:
> >>>
> >>>> Hi, I'd like to make a contribution to wix-maven-plugin. Where should
> I
> >>>> send the patch?
> >>>> Thanks.
> >>>> Adrián Boimvaser
> >>>
> >>>
> >>
>
> --
> Brett Porter
> br...@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
> http://twitter.com/brettporter
>
>
>
>
>
>

Reply via email to