[ 
https://issues.apache.org/jira/browse/NPANDAY-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914094#comment-13914094
 ] 

Brett Porter edited comment on NPANDAY-210 at 2/27/14 6:22 AM:
---------------------------------------------------------------

Addressed that one through NPANDAY-609 - note there's a slight compatibility 
risk there if someone had omitted one of the {{obj/\*/\*.g.cs}} files from 
includeSources, but this is a better solution all round.


was (Author: brettporter):
Addressed that one through NPANDAY-609 - note there's a slight compatibility 
risk there if someone had omitted one of the {{obj/*/*.g.cs}} files from 
includeSources, but this is a better solution all round.

> Deprecate includeSources in favor of include/exclude patterns
> -------------------------------------------------------------
>
>                 Key: NPANDAY-210
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-210
>             Project: NPanday
>          Issue Type: Bug
>          Components: Maven Plugins
>            Reporter: Brett Porter
>            Assignee: Lars Corneliussen
>            Priority: Minor
>             Fix For: 1.5.0-incubating
>
>
> This configuration was added to support certain types of Visual Studio 
> project nesting that we have concluded not to support. It currently slows the 
> build due to the extra copying and makes the POM harder to maintain. We 
> should remove it in favour of something closer to the Maven compiler plugin's 
> configuration, with <includes> and <excludes>, but defaulting to including 
> all relevant files.
> That is,
> - by default, csc is given all *.cs files in the source directory and 
> subdirectories; and vbc is given all *.vb files in the source directory and 
> subdirectories. No other files need be compiled.
> - files in target, bin, obj are excluded by default
> - files that are not a part of the csproj/vbproj (by being excluded or never 
> added) are excluded from compile by setting an <excludes> 
> <exclude>...</exclude> </excludes> configuration on the plugin. The addin 
> would be responsible for maintaining this - basically a reverse of the 
> current functionality, but much cleaner in its implementation and appearance, 
> and more robust against sync issues in the IDE.
> To implement the last point, the addin will need to be able to scan for the 
> available files in the same way as the compile plugin would, then add exclude 
> items for all that are not present in the csproj/vbproj, as excluded items 
> are not accessible from the project instances.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to