On 2 Apr 2014, at 7:18 am, Lars Corneliussen // Zen <[email protected]> wrote:
> Hi Brett, > > sorry for still not actively beeing watching the list :-( > > Still an issue? Would need to dive into it to give you feedback. No, I corrected the issue - I just wanted to check if you thought the change I made was correct, given it was a feature that you'd added. > > Hi Lars, > > I'm interested in your feedback here. I've made this change to be more > inline with the previous behaviour which used contentPath. I picked up on > this because it turns out the Resolve Web Roles mojo in the Azure plugin > assumes a contentPath destination, and fails if you use iisApp. > > Is this change correct, or should it in fact be iisApp now, and the resolve > mojo adjusted? > > (You can verify the behaviour through the Azure integration tests). > > Cheers, > Brett > > On 3 Mar 2014, at 8:55 pm, [email protected] wrote: > >> Author: brett >> Date: Mon Mar 3 09:55:30 2014 >> New Revision: 1573504 >> >> URL: http://svn.apache.org/r1573504 >> Log: >> [NPANDAY-488] Use contentPath by default >> >> This was the previous behaviour: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/plugins/msdeploy- >> maven-plugin/src/main/java/npanday/plugin/msdeploy/create/CreateConten >> tPackageMojo.java?r1=1333788&r2=1332286&pathrev=1333788 >> >> Also, there is a problem using iisApp with resolve web roles, since it >> expects the contentPath destination: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/plugins/msdeploy- >> maven-plugin/src/main/java/npanday/plugin/msdeploy/create/CreateConten >> tPackageMojo.java?r1=1333788&r2=1332286&pathrev=1333788 >> >> Modified: >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /main/csharp/Converter/Algorithms/ASPNetPomConverter.cs >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /test/resource/MvcApplication1/MvcApplication1/pom.test >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /test/resource/NPANDAY_480_AzureSupportOneWebRole/HelloWorld_WebRole/pom.tes > t >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /test/resource/NPANDAY_480_CloudServiceWithMultipleRoles/HelloWorld_WebRole/ > pom.test >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /test/resource/NPANDAY_488/NPANDAY_488_MSDeployPackageSimpleWebApp/pom.test >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /test/resource/SilverlightApplication1/SilverlightApplication1.Web/pom.test >> > incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engine/src > /test/resource/SilverlightApplication5/SilverlightApplication5.Web/pom.test >> >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/WebAppWithCultureRes/WebAppWithCultureRes/pom.tes >> t >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/main/csharp/Converter/Algorithms/ASPNetPomConverter.cs >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/main/csharp/Converter/Algorithms/A >> SPNetPomConverter.cs?rev=1573504&r1=1573503&r2=1573504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/main/csharp/Converter/Algorithms/ASPNetPomConverter.cs >> (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/main/csharp/Converter/Algorithms/ASPNetPomConverter.cs >> +++ Mon Mar 3 09:55:30 2014 >> @@ -54,7 +54,7 @@ namespace NPanday.ProjectImporter.Conver >> } >> >> Plugin msdeployPlugin = > AddPlugin("org.apache.npanday.plugins", "msdeploy-maven-plugin", null, > false); >> - AddPluginExecution(msdeployPlugin, "create-msdeploy-package", > new string[] { "create-iisApp-package" }, null); >> + AddPluginExecution(msdeployPlugin, >> + "create-msdeploy-package", new string[] { "create-content-package" >> + }, null); >> >> if (projectDigest.SilverlightApplicationList != null) >> { >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/MvcApplication1/MvcApplication1/pom.test >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/MvcApplication1/MvcA >> pplication1/pom.test?rev=1573504&r1=1573503&r2=1573504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/MvcApplication1/MvcApplication1/pom.test >> (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/MvcApplication1/MvcApplication1/pom.test >> +++ Mon Mar 3 09:55:30 2014 >> @@ -50,7 +50,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/NPANDAY_480_AzureSupportOneWebRole/HelloWorld_Web >> Role/pom.test >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/NPANDAY_480_AzureSup >> portOneWebRole/HelloWorld_WebRole/pom.test?rev=1573504&r1=1573503&r2=1 >> 573504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/NPANDAY_480_AzureSupportOneWebRole/HelloWorld_Web >> Role/pom.test (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/NPANDAY_480_AzureSupportOneWebRole/HelloW >> +++ orld_WebRole/pom.test Mon Mar 3 09:55:30 2014 >> @@ -50,7 +50,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/NPANDAY_480_CloudServiceWithMultipleRoles/HelloWo >> rld_WebRole/pom.test >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/NPANDAY_480_CloudSer >> viceWithMultipleRoles/HelloWorld_WebRole/pom.test?rev=1573504&r1=15735 >> 03&r2=1573504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/NPANDAY_480_CloudServiceWithMultipleRoles/HelloWo >> rld_WebRole/pom.test (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/NPANDAY_480_CloudServiceWithMultipleRoles >> +++ /HelloWorld_WebRole/pom.test Mon Mar 3 09:55:30 2014 >> @@ -50,7 +50,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/NPANDAY_488/NPANDAY_488_MSDeployPackageSimpleWebA >> pp/pom.test >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/NPANDAY_488/NPANDAY_ >> 488_MSDeployPackageSimpleWebApp/pom.test?rev=1573504&r1=1573503&r2=157 >> 3504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/NPANDAY_488/NPANDAY_488_MSDeployPackageSimpleWebA >> pp/pom.test (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/NPANDAY_488/NPANDAY_488_MSDeployPackageSi >> +++ mpleWebApp/pom.test Mon Mar 3 09:55:30 2014 >> @@ -50,7 +50,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/SilverlightApplication1/SilverlightApplication1.W >> eb/pom.test >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/SilverlightApplicati >> on1/SilverlightApplication1.Web/pom.test?rev=1573504&r1=1573503&r2=157 >> 3504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/SilverlightApplication1/SilverlightApplication1.W >> eb/pom.test (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/SilverlightApplication1/SilverlightApplic >> +++ ation1.Web/pom.test Mon Mar 3 09:55:30 2014 >> @@ -49,7 +49,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/SilverlightApplication5/SilverlightApplication5.W >> eb/pom.test >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/SilverlightApplicati >> on5/SilverlightApplication5.Web/pom.test?rev=1573504&r1=1573503&r2=157 >> 3504&view=diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/SilverlightApplication5/SilverlightApplication5.W >> eb/pom.test (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/SilverlightApplication5/SilverlightApplic >> +++ ation5.Web/pom.test Mon Mar 3 09:55:30 2014 >> @@ -49,7 +49,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> Modified: >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/WebAppWithCultureRes/WebAppWithCultureRes/pom.tes >> t >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies >> /NPanday.ProjectImporter/Engine/src/test/resource/WebAppWithCultureRes >> /WebAppWithCultureRes/pom.test?rev=1573504&r1=1573503&r2=1573504&view= >> diff >> ====================================================================== >> ======== >> --- >> incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/Engi >> ne/src/test/resource/WebAppWithCultureRes/WebAppWithCultureRes/pom.tes >> t (original) >> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.ProjectImporter/ >> +++ Engine/src/test/resource/WebAppWithCultureRes/WebAppWithCultureRes >> +++ /pom.test Mon Mar 3 09:55:30 2014 >> @@ -81,7 +81,7 @@ >> <execution> >> <id>create-msdeploy-package</id> >> <goals> >> - <goal>create-iisApp-package</goal> >> + <goal>create-content-package</goal> >> </goals> >> </execution> >> </executions> >> >> > > -- Brett Porter @brettporter http://brettporter.wordpress.com/ http://au.linkedin.com/in/brettporter
