[
https://issues.apache.org/jira/browse/NPANDAY-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060293#comment-14060293
]
Brett Porter commented on NPANDAY-632:
--------------------------------------
Good catch! Applied. For future patches, a couple of things you can do to
assist:
- take the patch from the root of the project, rather than in a submodule
- attach to the issue as a file that can be saved
An alternative is to send us a pull request against the Apache mirror of the
project's SVN repository.
> NPE when using netHome maven configuration
> ------------------------------------------
>
> Key: NPANDAY-632
> URL: https://issues.apache.org/jira/browse/NPANDAY-632
> Project: NPanday
> Issue Type: Bug
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Greg Domjan
> Fix For: 1.5.0-incubating
>
>
> When adding to the ilmerge-plugin the configuration
> {code}<netHome>\Some\Custom\Path<netHome>{code}
> Get an NPE when adding to the executableConfig.getExecutionPaths container
> before creating it.
> My quick fix was
> {code}
> ### Eclipse Workspace Patch 1.0
> #P org.apache.npanday.dotnet-executable
> Index: src/main/java/npanday/executable/impl/NetExecutableFactoryImpl.java
> ===================================================================
> --- src/main/java/npanday/executable/impl/NetExecutableFactoryImpl.java
> (revision 1609378)
> +++ src/main/java/npanday/executable/impl/NetExecutableFactoryImpl.java
> (working copy)
> @@ -85,6 +85,8 @@
> ? new ArrayList<String>()
> : executableConfig.getExecutionPaths();
>
> + executableConfig.setExecutionPaths( executablePaths );
> +
> if ( netHome != null )
> {
> getLogger().info( "NPANDAY-066-014: Found executable path in
> pom: Path = " + netHome.getAbsolutePath() );
> @@ -92,8 +94,6 @@
> }
>
>
> - executableConfig.setExecutionPaths( executablePaths );
> -
> final ExecutableCapability executableCapability =
> capabilityMatcher.matchExecutableCapabilityFor(
> executableRequirement );
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
