On Tue, 4 Mar 2008, SF Markus Elfring wrote: > > See objdump(1), size(1), etc. > > My update suggestion for array variables belongs to the open issue "cleanup > patches for strings". > http://lkml.org/lkml/2005/6/21/16
Suggestions are not always helpful, there are more important ares to work on: As I just mentioned, the discussion which I referred before and which you now link to is not conclusive. It may depend on the platform what is better. On x86_64, it seems it saves two bytes per use of the string in the assembly but you would have to check that nobody does sizeof() of that string because that value changes with your changes. In any case it's not significant in the case of ntfs-3g as these strings are not printed at a significant number of places. With -O2 and stripped, the difference goes near zero. If you cleanup your patch to only contain the string changes, I would be able to do do a comparsion on the final binary size and in addition, we'd need a script (maybe grep with context using -B 2 is sufficient) to check whether any sizeof() is taken anywere. You would need to check that. > http://kernelnewbies.org/KernelJanitors/Todo That page is sadly not informative enough of the issue. If omits the possible problem of sizeof() possibly being used on the string and the patch submitted in the lkml thread above was not merged into the kernel. Bernhard ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
