Luca: As promised, I have applied BMS0087, the "Great Debug Cleanup Patch" to the cvs, along with a # of small cleanup stuff...
Attached are all of the 2.1 patches I have in progress, for your review &
inclusion. Please ignore any similarly named files you may have from me
previously.
BMS0086-deaddata.patch
Minor - removes two un-referenced data items from myGlobals.
Should be easy to apply.
BMS0090-solaris-syslog.patch
Medium - This finishes the --use-syslog stuff with two alternatives, so
that it works for gcc compiling, as well as for Solaris 8 and other *nixes
without the gnu gcc facilitynames extension. This patch also
makes --use-syslog=facility work as defined in the documentation and help
text - you may remember disabling it because it broke under Solaris. I have
tested it in Linux and compiled under Solaris (I can't get my i86 Solaris 8
box to link ntop).
Please test this under Solaris and apply.
BMS0091-globaldata-initialize-c.patch
Minor - This replaces the file-global variable threadsInitialized in
initialize.c with a myGlobals one (myGlobals.hostsHashMutexInitialized), as
we discussed on list. Basically, if ntop comes up, it's worked - this code
prevents the resetStats() call done during startup from setting the mutex,
because it hasn't yet been created.
BMS0093-tcpwrapper-fixup.patch
Medium - when we moved stuff into myGlobals, we broke tcp_wrappers. The
internal wrappers code uses the allow_severity and deny_severity variables.
So I moved them back out. Also cleaned up the configure stuff and the
actual openlog() call. I #defined new values for this log:
#define NTOP_DEFAULT_TCPWRAP_ALLOW LOG_AUTHPRIV|LOG_INFO
#define NTOP_DEFAULT_TCPWRAP_DENY LOG_AUTHPRIV|LOG_WARNING
although only _DENY is used.
I've tested under RedHat Linux with a variety of combinations and it now
works great.
BMS0094-ipv6header-fixup.patch
Minor - Solaris 2.6 and 2.7 don't have the IPv6 definition (in6_addr)
that sFlowPlugin.c uses. (Solaris 8 and Linux are OK). A user has tested
this for me on 2.7, no response yet re 2.6.
After this, all I know of is documentation related stuff...
-----Burton
BMS0086-deaddata.patch
Description: Binary data
BMS0090-solaris-syslog.patch
Description: Binary data
BMS0091-globaldata-initialize-c.patch
Description: Binary data
BMS0093-tcpwrapper-fixup.patch
Description: Binary data
BMS0094-ipv6header-fixup.patch
Description: Binary data
