Luca: I don't think it's acceptable to inaccurately display data if it's at all possible to fix it and let's be honest, the current way of displaying these charts is inaccurate for small (15% and less...) values.
The increase in page size (6 or 8 lines) from this fix is small, and I've found ways to make it more readable. There's no reason to abandon the basic concept... just some bugs to fix... So, I'm going to wrassle this one to the ground - it's important to me! I've fixed up the change, done more extensive testing and I'm sending you the patch. There was a stray <TD> and </TR> tags in the generated HTML. In my defense, it worked fine on IE and Mozilla (Netscape 6.2 plus Mozilla 1.0 itself). It's just archaic versions of Netscape that choke on the (admittedly malformed) html. But I'll agree it should be fixed - the rest of the difference between v1 and v2 of this patch is just making it easier to read the bars... It now works fine on Netscape 4.61(Win), 4.78(Linux), 4.79(Win), 6.2.2(Win) IE 5.5 and 6.0 Galeon 1.2.5 (Linux) Mozilla 1.0 (Linux) Konqueror 2.2.2 (Linux) It works poorly on Opera 6 - 6.03(Win) and 6.0(Linux). It's not WRONG, it's just that the bar chart takes up only a small amount of the available space on the row. It's a trade-off: Opera doesn't handle nested percentages for table cell widths (well), while (older) Netscapes don't handle absolute values at all... Since you use NS4.61, working on NS and stiffing Opera was the best choice -- otherwise we start getting into handling user-agent headers and generating different code for different browsers... -----Burton -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of [EMAIL PROTECTED] Sent: Monday, September 30, 2002 5:01 AM To: [EMAIL PROTECTED] Subject: [Ntop-dev] New ntop commit (author deri) Update of /export/home/ntop/ntop In directory jabber:/tmp/cvs-serv20261 Modified Files: reportUtils.c Log Message: Reverted code for printTableEntryPercentage(). The old code is between #if 0. The current code produces less HTML and more compact tables (and more readable IMHO). _______________________________________________ Ntop-dev mailing list [EMAIL PROTECTED] http://lists.ntop.org/mailman/listinfo/ntop-dev
BMS0133-FixFakeBarCharts-v2.patch
Description: Binary data
