In this day an age, can't handle an unaligned move? Amazing. Yes, please do send in the whole-enchilada patch. Probably best would be to [EMAIL PROTECTED] so Luca looks at it.
-----Burton -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Chris Turbeville Sent: Thursday, August 28, 2003 12:46 AM To: [EMAIL PROTECTED] Subject: Re: [Ntop-dev] (was Sparc Sol9 patches) > > Are you saying that the Sparc platform can't handle an unaligned move? > > E.g another case of this comment? > > /* Need to copy this over in case bp isn't properly aligned. > * This occurs on SunOS 4.x at least. > * Paul D. Smith <[EMAIL PROTECTED]> > */ > > Or is it that this (@922) > > memcpy(&tp, bp+hlen, sizeof(struct tcphdr)); > > is duplicated by the lines in the fingerprint routine? If that's the case, > then shouldn't ALL the code in that block, 954..1032, be changed to use tp > and drop tcp all together? Yea I can send that in as that is what I've done. The problem is bp isn't aligned so when the tcpheader * tries to refer to th_off it is a nonaligned ref and bombs. I have a patch converting all of the finger print stuff to tp based instead of the tcp pointers. I'll send that in instead. -Chris > > -----Burton > > > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf > Of Chris Turbeville > Sent: Tuesday, August 26, 2003 9:31 PM > To: [EMAIL PROTECTED] > Subject: [Ntop-dev] Sparc Sol9 patches > > > Here's the summary of the work I've done to get NTOP running on Solaris: > > <snip/> > > This is the standard sparc alignment fix. > Index: ntop/pbuf.c > =================================================================== > RCS file: /export/home/ntop/ntop/pbuf.c,v > retrieving revision 2.135 > diff -r2.135 pbuf.c > 963c963 > < u_char *tcp_data = (u_char *)((int)tcp + tcp->th_off * 4); > --- > > u_char *tcp_data = (u_char *)((int)tcp + tp.th_off * 4); > > <snip/> > > -- > [EMAIL PROTECTED] Chris Turbeville > NTT/VERIO > Send mail with subject "send PGP Key" for PGP 6.5.2 Public key > > > _______________________________________________ > Ntop-dev mailing list > [EMAIL PROTECTED] > http://listgateway.unipi.it/mailman/listinfo/ntop-dev > -- [EMAIL PROTECTED] Chris Turbeville NTT/VERIO Send mail with subject "send PGP Key" for PGP 6.5.2 Public key _______________________________________________ Ntop-dev mailing list [EMAIL PROTECTED] http://listgateway.unipi.it/mailman/listinfo/ntop-dev _______________________________________________ Ntop-dev mailing list [EMAIL PROTECTED] http://listgateway.unipi.it/mailman/listinfo/ntop-dev
