I installed the new init script and it seems to operate fine except for a couple of nits:
The statement "extra=" -d --use-syslog=local3" should probably not be hard coded in the "normally modified parameters" section of this script. Commenting the statement would be ok if you are providing an example. My thought here is that not everyone reads every release note or readme file and could easily miss the statement if they are not familiar with ntop. The bad part is that it is missed the statement will prevent any logging on most systems where local3 is not normally configured. It could end up being a source of support inquiries. There are a few extra echo statements in the code that cause the script to skip four lines when you are starting ntop and a couple if you are invoking anything else with it. Yah you could say this is picky, but it has a detrimental effect in use. In a large environment, the guy that installed it is not the same one dealing with it periodically. To an unsuspecting SA who is booting the machine, he will probably think "what was that" when ntop causes the screen to jump four lines and go look for what might be wrong with ntop or the process before it or possible four others that didn't display correctly. Or worse, some "brain surgeon" data center operator calls you at 2AM because he saw this unusual behavior during a maintenance reboot. Here are the offending echo statements in the code: Two are located after the script sources the network configuration and the other two are located at the beginning of the start() function. I didn't have the time now to look at the script in detail, but it started ntop ok. There are some extra interface logging statements in the syslog where I have the interface defined in ntop.conf, but it didn't have any ill effects. I definitely prefer the new coding style though. I tend to follow whatever style is already in use, but all the expression quoting was getting out there. Tim
<<attachment: winmail.dat>>
