The "right" fix is to convert each counter to a #define name in a pattern
like this:
static char *rrdNames[] = {
#define CONST_RRD_ARPRARP_BYTES "arpRarpBytes"
CONST_RRD_ARPRARP_BYTES,
#define CONST_RRD_ATALK_BYTES "atalkBytes"
CONST_RRD_ATALK_BYTES,
...
Then you have to make the code use that #define everywhere! That way you
don't miss any of them in rrdNames.
It's not a hard change, just tedious.
-----Burton
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf
Of Robbert Kouprie
Sent: Wednesday, March 30, 2005 8:41 AM
To: [email protected]
Subject: RE: [Ntop-dev] Additional RRD filenames for the rrdNames list?
Ok, for now I'll just add them to the list in rrdPlugin.h
-- Robbert
On Wed, 30 Mar 2005, Burton Strauss wrote:
> The drop down is populated based on the protocol names (generated) and
> actual counter names (via static char *rrdNames[] = {} in
> rrdPlugin.h), but I could have missed some, esp. the combined names
> such as you list. These should probably be chased down and manually added
to the list.
>
> Even better would be some way of scanning for this, but don't even
> think about walking the directory - that can take forever.
>
> -----Burton
>
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
> Behalf Of Robbert Kouprie
> Sent: Wednesday, March 30, 2005 6:43 AM
> To: [email protected]
> Subject: [Ntop-dev] Additional RRD filenames for the rrdNames list?
>
> Hi,
>
> Concerning the "Arbitrary RRD Actions" page, shouldn't the RRD
> filenames with suffixes "Loc", "Rem" and "FromRem" be added to the RRD
> filenames list in rrdPlugin.h ?
>
> Currently it is not possible to generate arbitrary RRD graphs from
> data in files with these suffixes because there not listed in the
> select box on the page.
>
> For example, the list includes "bytesSent.rrd", but not "bytesSentLoc.rrd"
> or "bytesSentRem.rrd". These files do get created by ntop.
>
> -rw------- 1 ntop ntop 35292 Mar 30 13:59 bytesSentLoc.rrd
> -rw------- 1 ntop ntop 35292 Mar 30 13:59 bytesSentRem.rrd
> -rw------- 1 ntop ntop 35292 Mar 30 13:59 bytesSent.rrd
>
> Regards,
> Robbert
> _______________________________________________
> Ntop-dev mailing list
> [email protected]
> http://listgateway.unipi.it/mailman/listinfo/ntop-dev
>
> _______________________________________________
> Ntop-dev mailing list
> [email protected]
> http://listgateway.unipi.it/mailman/listinfo/ntop-dev
>
>
>
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
