I think not - as we talked about off list, most of your ideas were already
incorporated in the file I used for 3.2rc1 from your earlier .diffs (I just
didn't get around to committing the version I actually used to the cvs).
But it's a general good idea for anyone who wants to contribute patches to
use -U3. The patch Kenneth sent had lots of lines like this:
5,7c11,13
< Version: 3.1
< Release: 0
< Source: ntop-3.1.tgz
---
> Version: %{rpmversion}
> Release: %{rpmrelease}
> Source: ntop-%{version}%{versuffix}.tgz
Which work fine - there's an was/is set for patch to figure out. But pure
inserts:
2a3,8
> # next 3 variables should be changed at tarball-creation time
> %define rpmversion 3.2
> %define versuffix rc1
> # next starts with 0 for prereleases and betas, 1 for final
> %define rpmrelease 0.%{versuffix}
>
Just have line #s and will apply regardless of whether that makes sense!
-----Burton
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf
Of Kenneth Porter
Sent: Saturday, October 01, 2005 8:44 PM
To: [email protected]
Subject: RE: [Ntop-dev] RPM changes for 3.2rc1
--On Saturday, October 01, 2005 5:20 PM -0500 Burton Strauss
<[EMAIL PROTECTED]> wrote:
> 1. Use -U3 on your diff command). Patches w/o context are useless
> (-U3 would put some context on the initial addition of lines, w/o U3
> it will just blindly do whatever the line #s tell it to do, whether it
> makes sense or not...)
Doh, sorry about that. I knew I'd forget at least one thing in posting the
patch. ;) Let me know if it would still be useful, as I still have the
source files.
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
_______________________________________________
Ntop-dev mailing list
[email protected]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev
