Reporting splits 'tween http.c (which understands the http: request),
report.c and reportUtils.c
Discuss code changes in ntop-dev -- I'm happy to review design stuff.
Post code to [EMAIL PROTECTED] -- I find a diff -U3 works best.
What typically happens that Luca will want to review your stuff for a while,
until he gets comfortable with your abilities, style, etc. -- after that,
well, you can request read/write access to the cvs if you thing it's
beneficial.
Work modularly.
Don't reformat Luca's code - he doesn't like that!
Use #ifdef (esp. if you are folding something in that may break - it's
better to make it a compile or run-time parameter -- see the stuff I've done
on sigpipe as an example).
Adding counters? Don't forget to reset them in util.c and output them in
emitter.c
Style I'm trying to enforce - define a xxxx_DEBUG (e.g. IPSEC_DEBUG)
variable in ntop.h
Code your debug messages:
traceEvent(TRACE_ERROR, "xxxx_DEBUG: xxxxx %s", tmpBuf);
(So you can pick 'em out of the log!)
If you want to post a large experimental patch, send it to me and I'll throw
it up on SourceForge.
-----Burton
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Karl
Kranich
Sent: Friday, August 02, 2002 10:40 AM
To: [EMAIL PROTECTED]
Subject: RE: [Ntop] New "feature" for NTOP
I would be interested in working on this some (I'd especially like to add
IPSEC reporting for our Internet link).
I've never worked on a collaborative programming project like this, so that
leads to a few questions:
1. I'll need to extend the packet decoding and the reporting. I can look
at the icmp section of the packet decoding. Where would the reporting
functionality be added?
2. How do I submit code to be included in the project?
thanks,
Karl Kranich
-----Original Message-----
From: Burton M. Strauss III [mailto:[EMAIL PROTECTED]]
Sent: Thursday, August 01, 2002 12:42 PM
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: RE: [Ntop] New "feature" for NTOP
Write the code, we'll be happy to include it.
The code handling ICMP is a model - it too is an Ethernet but not TCP/IP
protocol.
Remember that the mission of ntop is to pull information of interest to
network admins out of the data streams. Let that drive what you
I would suggest creating a header tab like "IP Traffic" for "Other
Protocols". Then have left menu pages for specific protocols.
-----Burton
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of
Pierotti, Phil
Sent: Tuesday, July 30, 2002 5:21 PM
To: [EMAIL PROTECTED]
Subject: [Ntop] New "feature" for NTOP
I was wondering if anyone has looked into providing more complete support
for IPSEC VPN traffic in NTOP?
ISAKMP is standard TCP/UDP port, but the rest of IPSEC is different IP
protocol numbers (ie functionally at the same level as UDP and TCP) [esp =
protocol 50, ah = protocol 51]
It would be nice if NTOP could also track and display counters for this on
the "all protocols" page.
Others that come to mind at this level include GRE (protocol 47) , TLSP
(56), IPIP (94) , L2TP (115).
http://www.iana.org/assignments/protocol-numbers
Just a thought.
Thanks,
Phil P
----------------------------------------------------------------------------
--
[EMAIL PROTECTED]
----------------------------------------------------------------------------
--
Phil Pierotti Ph: 408 376 5820
Senior Network Engineer Cell: 408 410 1818
eBay, Inc.
_______________________________________________
Ntop mailing list
[EMAIL PROTECTED]
http://lists.ntop.org/mailman/listinfo/ntop
_______________________________________________
Ntop mailing list
[EMAIL PROTECTED]
http://lists.ntop.org/mailman/listinfo/ntop
_______________________________________________
Ntop mailing list
[EMAIL PROTECTED]
http://lists.ntop.org/mailman/listinfo/ntop
_______________________________________________
Ntop mailing list
[EMAIL PROTECTED]
http://lists.ntop.org/mailman/listinfo/ntop
