It's right - gcc 3.2.1 tightened the rules for #define (so actually, I guess it's cpp)
But, once again, you did a down under on the patch - you need to diff old new not diff
new old
-----Burton
---------- Original Message ----------------------------------
From: Stanley Hopcroft <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
Date: Tue, 4 Feb 2003 13:12:50 +1100
>Dear Ladies and Gentlemen,
>
>On FreeBSD 4.7-RELEASE with gcc 2.95.4 20020320 [FreeBSD], the
>compilation of util.c fails with
>
>util.c:3622: badly punctuated parameter list in `#define'
>gmake[2]: *** [util.lo] Error 1
>gmake[2]: Leaving directory `/usr/home/anwsmh/build/ntop-2.1.56/ntop'
>gmake[1]: *** [all-recursive] Error 1
>gmake[1]: Leaving directory `/usr/home/anwsmh/build/ntop-2.1.56/ntop'
>gmake: *** [all] Error 2
>tsade>
>
>
>Here is a patch,
>
>tsade> diff -u util.c util.c.orig
>
>--- util.c Tue Feb 4 12:37:31 2003
>+++ util.c.orig Tue Feb 4 12:37:20 2003
>@@ -3619,7 +3619,7 @@
> __getopt_initialized = 1;
> }
>
>-# define NONOPTION_P (argv[optind][0] != '-' || argv[optind][1] ==
>'\0')
>+# define NONOPTION_P(argv[optind][0] != '-' || argv[optind][1] == '\0')
>
> if(nextchar == NULL || *nextchar == '\0')
> {
>
>I am not a developer so I don't know if this is sensible; however,
>compilation continues until ..
>
>Stay tuned.
>
>Yours sincerely.
>
>--
>------------------------------------------------------------------------
>Stanley Hopcroft
>------------------------------------------------------------------------
>
>'...No man is an island, entire of itself; every man is a piece of the
>continent, a part of the main. If a clod be washed away by the sea,
>Europe is the less, as well as if a promontory were, as well as if a
>manor of thy friend's or of thine own were. Any man's death diminishes
>me, because I am involved in mankind; and therefore never send to know
>for whom the bell tolls; it tolls for thee...'
>
>from Meditation 17, J Donne.
>_______________________________________________
>Ntop mailing list
>[EMAIL PROTECTED]
>http://listgateway.unipi.it/mailman/listinfo/ntop
>
____________________________________________________________
Free 20MB Web Site Hosting and Personalized E-mail Service!
Get It Now At Doteasy.com http://www.doteasy.com/et/
_______________________________________________
Ntop mailing list
[EMAIL PROTECTED]
http://listgateway.unipi.it/mailman/listinfo/ntop