I agree with Stephan and Eric especially it when can be done with existing
method. I'll add it to the PR and close it. Thanks for the suggestions /
comments!

Regards,
ZJ

On Tue, Dec 10, 2019 at 2:05 PM Eric Firing <efir...@hawaii.edu> wrote:

> I wasn't sure whether the discussion would be on the list or on Github,
> so I posted to the latter:
>
> https://github.com/numpy/numpy/pull/14922#issuecomment-564211192
>
> Eric
>
> On 2019/12/10 8:43 AM, Zijie Poh wrote:
> > Hi all,
> >
> > We've created a PR (#14922 <https://github.com/numpy/numpy/pull/14922>)
> > on adding keepdims to linspace / logspace / geomspace, which enables
> > linspace to directly take the output of min and max with keepdims =
> > True as the start and stop arguments. That is, the following two
> > linspace calls return the same result.
> >
> > np.linspace(
> >      arr.min(axis=ax),
> >      arr.max(axis=ax),
> >      axis=ax
> > )
> >
> > np.linspace(
> >      arr.min(axis=ax, keepdims=True),
> >      arr.max(axis=ax, keepdims=True),
> >      axis=ax, keepdims=True
> > )
> >
> > Please let me know if you have any questions / suggestions.
> >
> > Regards,
> > ZJ
> >
> > _______________________________________________
> > NumPy-Discussion mailing list
> > NumPy-Discussion@python.org
> > https://mail.python.org/mailman/listinfo/numpy-discussion
> >
>
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion@python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
_______________________________________________
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

Reply via email to