> appears to be poorly optimized. It should perform well, not poor neither heavily optimized. > this also makes it quite difficult to improve (with either a better compiler > or by hand). We can put the blame on Intel for not sharing their source code but honestly, it seems we had no other option except accept what they provide. > Some of the glaring issues are: > 1. register allocation / spilling > 2. rodata layouts / const-propagation of the values. > 3. Very odd use of internal functions that really ought to be inlined.
let me add to your list another two points: - It only works on Linux. - It only works with AVX512. > If so, are people open to patches that optimize them (either with new C > implementations are in the current assembly implementations). Hopefully, we will able to convert them to universal intrinsics (nep-38) one day. As one of the team, I will try to push more time for it. Thanks, Sayed. On Nov 6 2021, at 5:54 pm, Ralf Gommers <ralf.gomm...@gmail.com> wrote: > > > On Sat, Nov 6, 2021 at 1:18 PM Noah Goldstein <goldstein....@gmail.com > (mailto:goldstein....@gmail.com)> wrote: > > On Fri, Nov 5, 2021 at 1:38 PM Devulapalli, Raghuveer > > <raghuveer.devulapa...@intel.com (mailto:raghuveer.devulapa...@intel.com)> > > wrote: > > > > > > They are meant to be optimized. Any contribution to improve them further > > > is more than welcome. > > > > Fantastic. I don't see any tests for any of the functions in there. > > Does anyone know where I > > can find them? > > > Use the main NumPy test suite by updating the svml submodule to the commit > with your changes, then run the test suite the regular way (e.g. `python > runtests.py`). > > Cheers, > Ralf > > > _______________________________________________ > NumPy-Discussion mailing list -- numpy-discussion@python.org > To unsubscribe send an email to numpy-discussion-le...@python.org > https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ > Member address: se...@imavr.com
_______________________________________________ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-le...@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ Member address: arch...@mail-archive.com
