Nice overview! In my opinion section 5. Datetimes could benefit from some clarifications, and contains a couple of typos.
Let me start with the typos. I read "As in pure python, np.datetime64 is accompained by np.timedelta64 (stored as a single np.uint64) with the expectable arithmetic operators.” but it should be “np.int64” since time delta values are signed. "Leap seconds are supported: <code snippet> Leap seconds are not (but proposed) <code snippet>" Of course the first sentence should be “leap years”, which leads to my main point. It makes no sense to claim “leap year support” without specifying the relevant calendar. Thus I would suggest to clearly state, from the very begin of this section, that - calendrical calculations are performed using a proleptic Gregorian calendar <https://en.wikipedia.org/wiki/Proleptic_Gregorian_calendar <https://en.wikipedia.org/wiki/Proleptic_Gregorian_calendar>>, - Posix semantics is followed, i.e. each day comprises exactly 86400 SI seconds, thus ignoring the existence of leap seconds. I would also point out that this choice is consistent with python datetime. As what regards the promised future support for leap seconds, I would not mention it, for now. In fact leap second support requires a leap second table, which is not available on all platforms supported by numpy. Therefore the leap second table should be bundled and updated with every numpy release with the very undesirable effect that older version (with outdated tables) would behave differently from newer ones. Stefano
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-le...@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ Member address: arch...@mail-archive.com
