On 6/5/22 01:32, Stefan van der Walt wrote:
On Thu, May 5, 2022, at 12:00, Trevor Gross wrote:
I don't necessarily know that this should be enforced on CI off the
bat (though in the future it could be), but at least having the tool
available and easily usable would help to incrementally improve
codebase style, and remove the need for formatting by hand.
On all projects we've set up pre-commit with style formatting, it has
significantly reduced noise and nitpicks in PR discussions. It makes
for a better contributor experience, thus I am in favor. Black isn't
perfect by any means, but never having to talk about formatting again
makes it worth it!
Stéfan
I (and maybe some others) am missing some context.
This somehow runs when I do "git commit"? Do I need to add anything to
my git environment to pick up the hook? How do I turn it off if I find
it prevents progress or breaks? Do we need to add anything to the
documentation to warn developers about possible complications or errors?
If it runs locally before committing, what does "enforce on CI" mean and
how is that different from the current linting CI job?
Matti
_______________________________________________
NumPy-Discussion mailing list -- numpy-discussion@python.org
To unsubscribe send an email to numpy-discussion-le...@python.org
https://mail.python.org/mailman3/lists/numpy-discussion.python.org/
Member address: arch...@mail-archive.com
