Thanks for the feedback Stephan and Hameer.

To close the loop on this topic, here is the PR I just opened:
https://github.com/numpy/numpy/pull/23376

Cheers,
Ralf


On Fri, Mar 10, 2023 at 10:26 PM Hameer Abbasi via NumPy-Discussion <
numpy-discussion@python.org> wrote:

> +1 from my side as well.
>
> Von meinem iPhone gesendet
>
> Am 10.03.2023 um 19:10 schrieb Stephan Hoyer <sho...@gmail.com>:
>
> 
> +1 for removing this environment variable. It was never intended to stick
> around this long.
>
> On Fri, Mar 10, 2023 at 6:48 AM Ralf Gommers <ralf.gomm...@gmail.com>
> wrote:
>
>> Hi all,
>>
>> In https://github.com/numpy/numpy/pull/23364 we touched on the
>> NUMPY_EXPERIMENTAL_ARRAY_FUNCTION environment variable. This was a
>> temporary feature during the introduction of `__array_function__` (see NEP
>> 18), but we never removed it. I propose we do so now, since it is
>> cumbersome to have around (see gh-23364 for one reason why). GitHub code
>> search shows some usages, but that's mostly old code to explicitly enable
>> it or print diagnostic info it looks like - none of it seemed relevant.
>>
>> In case there is any need for this functionality to disable
>> `__array_function__`, then please speak up. In that case it probably
>> applies to `__array_ufunc__` as well, and there should be a better way to
>> do this than an undocumented environment variable with "experimental" in
>> the name.
>>
>> Cheers,
>> Ralf
>>
>> _______________________________________________
>> NumPy-Discussion mailing list -- numpy-discussion@python.org
>> To unsubscribe send an email to numpy-discussion-le...@python.org
>> https://mail.python.org/mailman3/lists/numpy-discussion.python.org/
>> Member address: sho...@gmail.com
>>
> _______________________________________________
> NumPy-Discussion mailing list -- numpy-discussion@python.org
> To unsubscribe send an email to numpy-discussion-le...@python.org
> https://mail.python.org/mailman3/lists/numpy-discussion.python.org/
> Member address: hameerabb...@yahoo.com
>
> _______________________________________________
> NumPy-Discussion mailing list -- numpy-discussion@python.org
> To unsubscribe send an email to numpy-discussion-le...@python.org
> https://mail.python.org/mailman3/lists/numpy-discussion.python.org/
> Member address: ralf.gomm...@googlemail.com
>
_______________________________________________
NumPy-Discussion mailing list -- numpy-discussion@python.org
To unsubscribe send an email to numpy-discussion-le...@python.org
https://mail.python.org/mailman3/lists/numpy-discussion.python.org/
Member address: arch...@mail-archive.com

Reply via email to