The text of the NEP is a bit difficult to read in parts. Some of the proposed changes are buried in comments in the code examples, and in some sections it's not clear what is actually being proposed. Parts of it read more like notes rather than a completed NEP. I would suggest moving all English text outside of code blocks, and making sure that complete English sentences are used everywhere.
Aaron Meurer On Fri, Sep 15, 2023 at 12:14 PM Ralf Gommers <ralf.gomm...@gmail.com> wrote: > > Hi all, > > A lot of work has been happening to implement NEP 52 > (https://numpy.org/neps/nep-0052-python-api-cleanup.html) over the past 1.5 > months - mostly work by Mateusz Sokol, and review effort of Sebastian, Nathan > and myself. The majority of API changes have been made. There's more to do of > course and there are pending PRs for a good fraction of that. These two > tracking issues cover a lot of ground and discussion around decision on > individual APIs: > > - main namespace: https://github.com/numpy/numpy/issues/24306 > - numpy.lib namespace: https://github.com/numpy/numpy/issues/24507 > > This PR with a migration guide will give a good sense of what has been > removed or changed so far: https://github.com/numpy/numpy/pull/24693. > > In https://github.com/numpy/numpy/pull/24620 the NEP itself is being updated > for changes that have been made. And it will mark the NEP as Accepted, which > seems about time given that a lot of the work has already been merged. > > If there are no substantive objections within 7 days from this email, then > the NEP will be accepted; see NEP 0 for more details. > > Cheers, > Ralf > > _______________________________________________ > NumPy-Discussion mailing list -- numpy-discussion@python.org > To unsubscribe send an email to numpy-discussion-le...@python.org > https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ > Member address: asmeu...@gmail.com _______________________________________________ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-le...@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ Member address: arch...@mail-archive.com
