On Mon, Jul 22, 2024 at 3:36 AM Jake S. <jacob.stevens.h...@gmail.com> wrote:
> Hi all, it's been a couple of months, so I'm asking for a review again > <https://github.com/numpy/numpy/pull/26081> of my typing PR. Original > reviewer requested a useful additional feature, but hasn't been able to > provide feedback since then. The feature turned out to be problematic and > fragile without a PEP on TypeVarTuple covariance/bounds. I've needed a > decision on whether I should (a) do the feature, leaving out difficult > tests until the feature is supported by python, and note this in the docs, > (b) remove that feature from the PR (my choice), > You and Joren both seem to be in favor of (b), so going with that is the way to go. > or (c) commit to a compromise that will be non-ideal when python *does* > support the feature. > > I'd like to know the path forward from someone with approval authority; I > don't want to keep troubleshooting and maintaining the PR without a way > forward. > Thanks for bringing this up here Jake, and for all your work on this PR. I hope we've just resolved this issue ( https://github.com/numpy/numpy/pull/26081#issuecomment-2246283338). Cheers, Ralf > > Thanks, > Jake > > > Jake Stevens-Haas > Ph.D. Candidate > Applied Mathematics > University of Washington > +1-(908)-462-4196 > jacob.stevens.h...@gmail.com > j...@uw.edu > > > > On Tue, May 14, 2024 at 2:26 PM Jake S. <jacob.stevens.h...@gmail.com> > wrote: > >> Ah, thanks Nathan! Most of them resolved, but one still fails (macOS >> x86-64 conda >> <https://github.com/numpy/numpy/actions/runs/9085504902/job/24968997756>). >> The spin build gives Error: 'types.SimpleNamespace' object has no >> attribute 'dir_info'; aborting. Not sure if that relates to handling >> the gcov argument, or whether it will block the PR? >> >> - Jake >> >> Jake Stevens-Haas >> Ph.D. Candidate >> Applied Mathematics >> University of Washington >> +1-(908)-462-4196 >> jacob.stevens.h...@gmail.com >> j...@uw.edu >> >> >> >> On Tue, May 7, 2024 at 11:53 AM Nathan <nathan.goldb...@gmail.com> wrote: >> >>> I think most of the build failures you’re seeing would be fixed by >>> merging with or rebasing on the latest main branch. >>> >>> Note that there is currently an issue with some of the windows CI >>> runners, so you’ll see failures related to our spin configuration failing >>> to handle a gcov argument that was added in spin 0.9 released a couple days >>> ago. >>> >>> On Mon, May 6, 2024 at 8:48 PM Jake S. <jacob.stevens.h...@gmail.com> >>> wrote: >>> >>>> Hi community, >>>> >>>> PR 26081 <https://github.com/numpy/numpy/pull/26081> is about making >>>> numpy's ShapeType covariant and bound to a tuple of ints. The community >>>> has requested this occasionally in issue 16544 >>>> <https://github.com/numpy/numpy/issues/16544>. I'm reaching out via >>>> the listserv because it's been a few months, and I don't want it to get too >>>> stale. I could really use some help pushing it over the finish line. >>>> >>>> Summary: >>>> Two numpy reviewers and one interested community member reviewed the PR >>>> and asked for a type alias akin to npt.NDArray that allowed shape. I >>>> worked through the issues with TypeVarTuple and made npt.Array, and it was >>>> fragile, but passing CI. After a few months passed, I returned to fix the >>>> fragility in the hopes of getting some more attention, but now it fails CI >>>> in some odd builds (passes the mypy bit). I have no idea how to get these >>>> to pass, as they appear unrelated to anything I've worked on (OpenBLAS on >>>> windows, freeBSD...?). >>>> >>>> Thanks, >>>> Jake >>>> _______________________________________________ >>>> NumPy-Discussion mailing list -- numpy-discussion@python.org >>>> To unsubscribe send an email to numpy-discussion-le...@python.org >>>> https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ >>>> Member address: nathan12...@gmail.com >>>> >>> _______________________________________________ >>> NumPy-Discussion mailing list -- numpy-discussion@python.org >>> To unsubscribe send an email to numpy-discussion-le...@python.org >>> https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ >>> Member address: jacob.stevens.h...@gmail.com >>> >> _______________________________________________ > NumPy-Discussion mailing list -- numpy-discussion@python.org > To unsubscribe send an email to numpy-discussion-le...@python.org > https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ > Member address: ralf.gomm...@googlemail.com >
_______________________________________________ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-le...@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ Member address: arch...@mail-archive.com
