Stefan, The changes look reasonable, and if the old tests still pass (I'm assuming your new ones will), then I'm happy.
There is one "style" issue: the (int* is_new_object) argument always appears last in those helper functions where it is used. Thanks On Aug 12, 2008, at 2:16 AM, Stéfan van der Walt wrote: > Hi all, > > I've given ticket #750 a shot. Since I was not previously familiar > with SWIG, I would appreciate it if those of you who know it could > take a look at the proposed patch: > > http://codereview.appspot.com/2890 > > Thanks for your time, > Stéfan ** Bill Spotz ** ** Sandia National Laboratories Voice: (505)845-0170 ** ** P.O. Box 5800 Fax: (505)284-0154 ** ** Albuquerque, NM 87185-0370 Email: [EMAIL PROTECTED] ** _______________________________________________ Numpy-discussion mailing list [email protected] http://projects.scipy.org/mailman/listinfo/numpy-discussion
