Hi Nadav
2008/8/6 Nadav Horesh <[EMAIL PROTECTED]>:
> I made the following modification to the source code, I hope it is ready to
> be included in scipy.
>
> Added a BSD licence declaration.
> Small optimisation.
> The code is split into a cython back-end and a python front-end.
>
> All remarks are welcome,
Thanks for working on a bilateral filter implementation. Some comments:
1. Needs a setup.py file to build the Cython module (simplest possible
is attached)
2. numpy.numarray.nd_image should be scipy.ndimage
3. For inclusion in SciPy, we'll need some tests and preferably some examples.
4. Docstrings should be in SciPy format.
5. ndarray.h should be numpy/ndarray.h
Thanks for writing this filter; I found it useful!
Cheers
Stéfan
from distutils.core import setup
from distutils.extension import Extension
from Cython.Distutils import build_ext
import numpy
setup(
cmdclass = {'build_ext': build_ext},
ext_modules = [Extension("bilateral_base", ["bilateral_base.pyx"],
include_dirs = [numpy.get_include()],
extra_compile_args=['-O3'])
]
)
_______________________________________________
Numpy-discussion mailing list
[email protected]
http://projects.scipy.org/mailman/listinfo/numpy-discussion
