Wed, 03 Jun 2009 16:05:51 -0400, David Warde-Farley wrote:

> On 2-Jun-09, at 3:06 PM, Pauli Virtanen wrote:
> 
>> +0
>>
>> I don't see any drawbacks, and the implementation looks good.
> 
> Thanks Pauli. I realized I was missing values() and itervalues() (though
> I can't conceive of a scenario where I'd use them myself, I guess some
> code might expect them). Also I should probably make a copy of
> self.files in keys() to prevent it from being mutated.
> 
> I've filed a ticket with the updated patch:
> 
>       http://projects.scipy.org/numpy/ticket/1125

Btw, are you able to change the status of the ticket to "needs_review"?
I think this should be possible for everyone, and not restricted to 
admins, but I'm not 100% sure...

-- 
Pauli Virtanen

_______________________________________________
Numpy-discussion mailing list
[email protected]
http://mail.scipy.org/mailman/listinfo/numpy-discussion

Reply via email to