On Tue, Aug 25, 2009 at 11:51 AM, Charles R Harris <
charlesr.har...@gmail.com> wrote:
> Hi Travis,
>
> The new parse_datetime.c file contains a lot of c++ style comments that
> should be fixed. Also, the new test for mirr is failing on all the
> buildbots.
>
Also,
1) There are two macros with gotos, which is a no-no. You could use inline
functions instead or just write out the code where needed.
2) Multiline comments like so:
/*
* blah, blah
*/
3) Think twice about using trailing comments.
4) The constant defines should be collected in one spot and documented.
5) Use blank lines between all function definitions.
6) Use {} around all if statement blocks
7) Format else like so:
}
else if (bug) {
blah;
}
8) The file contains hard tabs and trailing whitespace.
9) A number of lines are longer than 80 characters.
Yours Truly,
The Pedant ;)
_______________________________________________
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion
