On Tue, Aug 31, 2010 at 3:44 AM, David Huard <david.hu...@gmail.com> wrote:
>
> I just added a warning alerting concerned users (r8674), so this takes care
> of the bug fix and Nils wish to avoid a silent change in behavior. These two
> changes could be included in 1.5 if Ralf feels this is worthwhile.
>
> That looks like a reasonable solution. I haven't got a strong opinion on
whether or not to change the 'normed' keyword to 'density'.
Looking at the changes, I don't think that is the right way to do the
filtering in the tests. resetwarnings() removes all filters including the
ones previously set by users, and should therefore not be used. Better to
either raise a specific warning and filter on that, or to filter on the
message content with:
warnings.filterwarnings('ignore' , message="This release of NumPy fixes
a normalization bug in histogram").
I found one more place where resetwarnings() is used, in
test_arraysetops.py, I'll change that in trunk. Related problem there is
that the warning in warnings.warn is not a DeprecationWarning.
The above problem is easy to fix, but in any case it's too late to go into
1.5.0 - I'll tag the final release tonight.
Cheers,
Ralf
_______________________________________________
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion
