On Wed, Jan 5, 2011 at 9:30 AM, Skipper Seabold <jsseab...@gmail.com> wrote:
> On Tue, Jan 4, 2011 at 1:49 PM, Justin Peel <jpsc...@gmail.com> wrote: > > Hi all, > > > > I've been submitting some patches recently just by putting them on > > Trac. However, I noticed in the Numpy Developer Guide that it says: > > > > The recommended way to proceed is either to attach these files to > > an enhancement ticket in the Numpy Trac and send a mail about the > > enhancement to the NumPy mailing list. > > > > This line is rather confusing. Either the 'either' should be removed > > or 'and'->'or'. In other words, is it sufficient to submit the patch > > in Trac or should I also be emailing the Numpy mailing list about each > > patch I submit? > > > > I am not positive, but I think that having them on Trac ensures that > they're not lost and is sufficient. An e-mail serves to draw some > attention (or not) for a review or speedier inclusion. > > Should this recommendation in the docs be changed or amended with the > switch to git? > > Skipper > At the very least, the wording is grammatically incorrect and should be fixed. Ben Root
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
