On Fri, Jul 8, 2011 at 11:06 PM, Mark Wiebe <[email protected]> wrote:
> On Fri, Jul 8, 2011 at 10:04 PM, Eric Firing <[email protected]> wrote: > >> On 07/08/2011 01:31 PM, Mark Wiebe wrote: >> > I've just made pull request 105: >> > >> > https://github.com/numpy/numpy/pull/105 >> > >> > This adds public API PyArray_MaskedCopyInto and PyArray_MaskedMoveInto, >> > which behave analogously to the corresponding unmasked functions. To >> > expose this with a reasonable interface, I added a function np.copyto, >> > which takes a 'where=' parameter just like the element-wise ufuncs. >> > >> > One thing which needs discussion is that I've flagged 'putmask' and >> > PyArray_PutMask as deprecated, because 'copyto' PyArray_MaskedMoveInto >> > handle what those functions do but in a more flexible fashion. If there >> > are any objections to deprecating 'putmask' and PyArray_PutMask, please >> > speak up! >> >> Mark, >> >> Looks good! Some quick tests with large and small arrays show copyto is >> faster than putmask when the source is an array and only a bit slower >> when the source is a scalar. >> > > With a bit of effort into performance optimization, it can probably be > faster in the scalar cases as well. Currently, the masked case is always a > function which calls the unmasked inner loop for the values that are > unmasked. A faster way would be to create inner loops that handle the mask > directly. > > Are you planning on doing that somewhere down the line? I'm going to push this with some style and typo mods. Chuck
_______________________________________________ NumPy-Discussion mailing list [email protected] http://mail.scipy.org/mailman/listinfo/numpy-discussion
