I think we should go ahead and merge this PR. It would be ideal to make a branch with the current code and then merge this into master.
I haven't had the time to do this. If you can do this Nathaniel, then it will really help with 1.7 release. Thanks, -Travis On Jun 14, 2012, at 11:17 AM, Nathaniel Smith wrote: > On Wed, Jun 6, 2012 at 11:08 PM, Nathaniel Smith <n...@pobox.com> wrote: >> Just submitted this pull request for discussion: >> https://github.com/numpy/numpy/pull/297 >> >> As per earlier discussion on the list, this PR attempts to remove >> exactly and only the maskna-related code from numpy mainline: >> http://mail.scipy.org/pipermail/numpy-discussion/2012-May/062417.html >> >> The suggestion is that we merge this to master for the 1.7 release, >> and immediately "git revert" it on a branch so that it can be modified >> further without blocking the release. >> >> The first patch does the actual maskna removal; the second and third >> rearrange things so that PyArray_ReduceWrapper does not end up in the >> public API, for reasons described therein. >> >> All tests pass with Python 2.4, 2.5, 2.6, 2.7, 3.1, 3.2 on 64-bit >> Ubuntu. The docs also appear to build. Before I re-based this I also >> tested against Scipy, matplotlib, and pandas, and all were fine. > > While it's tempting to think that the lack of response to this > email/PR indicates that everyone now agrees with me about how to > proceed with the NA work, I'm for some reason unconvinced... > > Any objections to merging this? > > -N > _______________________________________________ > NumPy-Discussion mailing list > NumPy-Discussion@scipy.org > http://mail.scipy.org/mailman/listinfo/numpy-discussion _______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
