On Fri, May 31, 2013 at 5:08 PM, Albert Kottke <albert.kot...@gmail.com>wrote:
> I noticed that genfromtxt() did not skip comments if the keyword names is > not True. If names is True, then genfromtxt() would take the first line as > the names. I am proposing a fix to genfromtxt that skips all of the > comments in a file, and potentially using the last comment line for names. > This will allow reading files with and without comments and/or names. > > The difference is here: > https://github.com/arkottke/numpy/compare/my-genfromtxt > > Careful with semantics here. First off, using the last comment line as the source for names might initially make sense, except when there are comments within the data file. I would suggest going for "last comment line before the first line of data". Second, sometimes the names come from an un-commented first line, but comments are still used within the file elsewhere. Just some food for thought. I don't know if the current design is best or not. Ben Root
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
