I don't have CFLAGS defined. But I have iothers env variable that point to other python stuff like CPATH.
But even in that case, I don't understand how other people could have compiled methods.c. The include aren't part of the env variable, but in the file. Anyway, I think your PR is the good fix. I checked our PR and now I have this new error: gcc: numpy/core/src/multiarray/multiarraymodule.c In file included from numpy/core/src/multiarray/multiarraymodule.c:3753:0: build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:303:18: error: ‘PyArray_Partition’ undeclared here (not in a function) build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:304:18: error: ‘PyArray_ArgPartition’ undeclared here (not in a function) In file included from numpy/core/src/multiarray/multiarraymodule.c:3753:0: build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:303:18: error: ‘PyArray_Partition’ undeclared here (not in a function) build/src.linux-x86_64-2.7/numpy/core/include/numpy/__multiarray_api.c:304:18: error: ‘PyArray_ArgPartition’ undeclared here (not in a function) error: Command "gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -O2 -fPIC -DHAVE_NPY_CONFIG_H=1 -Inumpy/core/include -Ibuild/src.linux-x86_64-2.7/numpy/core/include/numpy -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -I/opt/lisa/os/epd-7.1.2/include/python2.7 -c numpy/core/src/multiarray/multiarraymodule.c -o build/temp.linux-x86_64-2.7/numpy/core/src/multiarray/multiarraymodule.o" failed with exit status 1 So it seam we have the same problem with those 2 functions. They are defined in numpy/core/src/multiarray/item_selection.c, but not in the .h file. thanks Fred On Mon, Sep 9, 2013 at 11:44 AM, Charles R Harris <charlesr.har...@gmail.com > wrote: > > > > On Mon, Sep 9, 2013 at 9:33 AM, Frédéric Bastien <no...@nouiz.org> wrote: > >> I tried it and retried and it still fail. This is in an virtualenv >> >> $git show >> commit c9b06111227f7a4ec213571f97e1b8d19b9c23f5 >> Merge: 73fbfb2 8edccea >> Author: Charles Harris <charlesr.har...@gmail.com> >> Date: Sun Sep 8 19:47:21 2013 -0700 >> >> Merge pull request #3701 from cgohlke/patch-2 >> >> ENH: add support for Python 3.4 ast.NameConstant >> >> >> >> $rm -rf build ## Fail as there is no such directory >> $pip install . # fail with the same error >> >> $pip uninstall numpy >> $python setup.py install --user # fail with the same error >> $pip install . ## fail with the same error: >> >> $git grep PyArray_SelectkindConverter >> doc/release/1.8.0-notes.rst:* PyArray_SelectkindConverter >> numpy/core/code_generators/numpy_api.py: >> 'PyArray_SelectkindConverter': 298, >> numpy/core/src/multiarray/conversion_utils.c:PyArray_SelectkindConverter(PyObject >> *obj, NPY_SELECTKIND *selectkind) >> numpy/core/src/multiarray/methods.c: >> PyArray_SelectkindConverter, &sortkind, >> numpy/core/src/multiarray/methods.c: >> PyArray_SelectkindConverter, &sortkind, >> >> >> Here I don't see PyArray_SelectkindConverter in conversion_utils.h as you >> said it is present. Witch commit do you use? >> >> > It's not there, it is part of the API. I've got a PR to add it to the *.h > file. The question is why you are the only person (so far) to have a > problem compiling. What are your CFLAGS? > > Chuck > >> Fred >> >> >> >> On Mon, Sep 9, 2013 at 11:02 AM, Charles R Harris < >> charlesr.har...@gmail.com> wrote: >> >>> >>> >>> >>> On Mon, Sep 9, 2013 at 8:51 AM, Charles R Harris < >>> charlesr.har...@gmail.com> wrote: >>> >>>> >>>> >>>> >>>> On Mon, Sep 9, 2013 at 7:46 AM, Frédéric Bastien <no...@nouiz.org>wrote: >>>> >>>>> Hi, >>>>> >>>>> I checkout the dev version of numpy and it fail to compile with this >>>>> error: >>>>> >>>>> creating >>>>> build/temp.linux-x86_64-2.7/build/src.linux-x86_64-2.7/numpy/core/src/multiarray >>>>> >>>>> compile options: '-DHAVE_NPY_CONFIG_H=1 -Inumpy/core/include >>>>> -Ibuild/src.linux-x86_64-2.7/numpy/core/include/numpy >>>>> -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core >>>>> -Inumpy/core/src/npymath -Inumpy/core/src/multiarray >>>>> -Inumpy/core/src/umath >>>>> -Inumpy/core/src/npysort -Inumpy/core/include >>>>> -I/opt/lisa/os/epd-7.1.2/include/python2.7 -c' >>>>> >>>>> gcc: numpy/core/src/multiarray/sequence.c >>>>> >>>>> gcc: numpy/core/src/multiarray/descriptor.c >>>>> >>>>> gcc: numpy/core/src/multiarray/getset.c >>>>> >>>>> gcc: numpy/core/src/multiarray/arrayobject.c >>>>> >>>>> gcc: numpy/core/src/multiarray/methods.c >>>>> >>>>> numpy/core/src/multiarray/methods.c: In function ‘array_partition’: >>>>> >>>>> numpy/core/src/multiarray/methods.c:1199:38: error: >>>>> ‘PyArray_SelectkindConverter’ undeclared (first use in this function) >>>>> >>>>> numpy/core/src/multiarray/methods.c:1199:38: note: each undeclared >>>>> identifier is reported only once for each function it appears in >>>>> >>>>> numpy/core/src/multiarray/methods.c: In function ‘array_argpartition’: >>>>> >>>>> numpy/core/src/multiarray/methods.c:1316:38: error: >>>>> ‘PyArray_SelectkindConverter’ undeclared (first use in this function) >>>>> >>>>> numpy/core/src/multiarray/methods.c:1352:9: warning: assignment makes >>>>> pointer from integer without a cast >>>>> >>>>> numpy/core/src/multiarray/methods.c: In function ‘array_partition’: >>>>> >>>>> numpy/core/src/multiarray/methods.c:1199:38: error: >>>>> ‘PyArray_SelectkindConverter’ undeclared (first use in this function) >>>>> >>>>> numpy/core/src/multiarray/methods.c:1199:38: note: each undeclared >>>>> identifier is reported only once for each function it appears in >>>>> >>>>> numpy/core/src/multiarray/methods.c: In function ‘array_argpartition’: >>>>> >>>>> numpy/core/src/multiarray/methods.c:1316:38: error: >>>>> ‘PyArray_SelectkindConverter’ undeclared (first use in this function) >>>>> >>>>> numpy/core/src/multiarray/methods.c:1352:9: warning: assignment makes >>>>> pointer from integer without a cast >>>>> >>>>> error: Command "gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -O2 >>>>> -fPIC -DHAVE_NPY_CONFIG_H=1 -Inumpy/core/include >>>>> -Ibuild/src.linux-x86_64-2.7/numpy/core/include/numpy >>>>> -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core >>>>> -Inumpy/core/src/npymath -Inumpy/core/src/multiarray >>>>> -Inumpy/core/src/umath >>>>> -Inumpy/core/src/npysort -Inumpy/core/include >>>>> -I/opt/lisa/os/epd-7.1.2/include/python2.7 -c >>>>> numpy/core/src/multiarray/methods.c -o >>>>> build/temp.linux-x86_64-2.7/numpy/core/src/multiarray/methods.o" failed >>>>> with exit status 1 >>>>> >>>>> >>>>> PyArray_SelectkindConverter is defined in >>>>> numpy/core/src/multiarray/conversion_utils.c. methods.c include >>>>> conversion_utils.h, but there is no fct declaration of this fct in this >>>>> file. Is that normal? >>>>> >>>>> >>>> No, it looks like a bug. What is strange is that it doesn't show up on >>>> my machine. What compiler flags are you using? >>>> >>>> Could you make a PR for this? >>>> >>>> <snip> >>>> >>>> >>> Wait a minute, it is in the API. Try a clean build and see what happens. >>> >>> Chuck >>> >>>> >>>> >>> _______________________________________________ >>> NumPy-Discussion mailing list >>> NumPy-Discussion@scipy.org >>> http://mail.scipy.org/mailman/listinfo/numpy-discussion >>> >>> >> >> _______________________________________________ >> NumPy-Discussion mailing list >> NumPy-Discussion@scipy.org >> http://mail.scipy.org/mailman/listinfo/numpy-discussion >> >> > > _______________________________________________ > NumPy-Discussion mailing list > NumPy-Discussion@scipy.org > http://mail.scipy.org/mailman/listinfo/numpy-discussion > >
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion