Is this what I want? https://github.com/numpy/numpy/pull/3987
On Sun, Oct 27, 2013 at 9:42 PM, Neil Girdhar <[email protected]> wrote: > Yeah, I realized that I missed that and figured it wouldn't matter since > it was my own master and I don't plan on making other changes to numpy. If > you don't mind, how do I move my changelist into a branch? I'm really > worried I'm going to lose my changes. > > > On Sun, Oct 27, 2013 at 9:38 PM, Charles R Harris < > [email protected]> wrote: > >> >> >> >> On Sun, Oct 27, 2013 at 7:23 PM, Neil Girdhar <[email protected]>wrote: >> >>> This is my first code review request, so I may have done some things >>> wrong. I think the following URL should work? >>> https://github.com/MisterSheik/numpy/compare >>> >>> The first thing to do is make a new branch for your work. Probably the >> easiest way from where you are is to make the branch, which will have your >> changes in it, then go back to master and git reset --hard to the last >> commit before your work. Working in master is a big no-no. See >> `doc/source/dev/gitwash/development_workflow.rst`. When you are ready, make >> a PR for that branch. The code will get reviewed at that point. >> >> Chuck >> >> _______________________________________________ >> NumPy-Discussion mailing list >> [email protected] >> http://mail.scipy.org/mailman/listinfo/numpy-discussion >> >> >
_______________________________________________ NumPy-Discussion mailing list [email protected] http://mail.scipy.org/mailman/listinfo/numpy-discussion
