On Sa, 2014-07-05 at 22:13 -0400, Benjamin Root wrote: > Drats... I actually know those two topics... and I might have free > time tomorrow afternoon at SciPy. Maybe I could take a peek at it? >
Maybe if you have time. It is just the attempt_1d_fallback function in the pull request https://github.com/numpy/numpy/pull/4804 This is called only after the normal indexing code gave an exception already and maybe we can make the warnings more informative. - Sebastian > > Ben > > > > On Sat, Jul 5, 2014 at 11:24 AM, Sebastian Berg > <sebast...@sipsolutions.net> wrote: > On Sa, 2014-07-05 at 00:41 +0100, Nathaniel Smith wrote: > > On 5 Jul 2014 00:07, "Charles R Harris" > <charlesr.har...@gmail.com> > > > <snip> > > > > That is a massive pile of affected projects :-(. > > > > My worry is that if all these projects we know about are > broken, then > > how many other codebases that we aren't testing are also > broken? > > > > > Yeah, I would imagine quite a few might be. It isn't that I > guess many > used the "feature" deliberately, but it is easy to just code > it and > assume that the code is correct since it works. So I think I > will just > need to fix it. The pull request *should* already do this with > a band > aid-solution, by just falling back to the old funky stuff if > there is a > failure. If someone is good with python exception handling and > string > formatting in C, please feel free to have a look ;). > > - Sebastian > > > > If the issues are fixed in matplotlib and pandas I'd be > inclined to > > release as is with a mention of versions in the release > notes. > > > > Even if it's fixed in pandas master, how long until it's in > user's > > hands? > > > > -n > > > > > Chuck > > > > > > > > > _______________________________________________ > > > NumPy-Discussion mailing list > > > NumPy-Discussion@scipy.org > > > http://mail.scipy.org/mailman/listinfo/numpy-discussion > > > > > > > > > _______________________________________________ > > NumPy-Discussion mailing list > > NumPy-Discussion@scipy.org > > http://mail.scipy.org/mailman/listinfo/numpy-discussion > > > > _______________________________________________ > NumPy-Discussion mailing list > NumPy-Discussion@scipy.org > http://mail.scipy.org/mailman/listinfo/numpy-discussion > > > > _______________________________________________ > NumPy-Discussion mailing list > NumPy-Discussion@scipy.org > http://mail.scipy.org/mailman/listinfo/numpy-discussion
signature.asc
Description: This is a digitally signed message part
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion