Hello all,

I have PR #7325 <https://github.com/numpy/numpy/pull/7325/files> up that
changes the internal calls for functions in *fromnumeric.py* from
positional arguments to keyword arguments.  I made this change for two
reasons:

1) It is consistent with the external function signature
2)

The inconsistency caused a breakage in *pandas* in its own implementation
of *searchsorted* in which the *sorter* argument is not really used but is
accepted so as to make it easier for *numpy* users who may be used to the
*searchsorted* signature in *numpy*.

The standard in *pandas* is to "swallow" those unused arguments into a
*kwargs* argument so that we don't have to document an argument that we
don't really use.  However, that turned out not to be possible when
*searchsorted* is called from the *numpy* library.

Does anyone have any objections to the changes I made?

Thanks!

Greg
_______________________________________________
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion

Reply via email to