About PRs:
(not sure if I'm entitled to answer this, but my POV)
Generally, a PR should be opened when your code is (probably) ready to ship
(a release-candidate), then other devs should review it, may have comments,
request changes to it, this way you iterate until everyone is satisfied and
PR gets merged in.
I sometimes abuse this behavior when I open a work-in-progress PR, which I
do for two reasons: it's the most convenient way to discuss relevant code
lines, address interested people and have nice log of
comments/requests/ideas from others. The other is to "get to the public
eyes", eg when asking for help, or I think other people might start the
same work..so that it's visible on the main repo, so we don't waste
resources reinventing the wheel and instead ppl can collaborate in the
branch.
>From devs (git) point of view, you make changes to the branch and push them
to make public (sorry if stating the obvious).
True to say, last weeks we had quite a lot PRs accumulated in (not a bad
thing, per se), yet today was a great deal of work done! :) and the number
reduced a lot. Anyway, a suggestion, maybe we could have a day ("patch
Tuesday") when we try to test and review the most of PRs that didn't get
merged already, and try either state what else should be done, or merge in.
(This is not to say merge all pull requests on Tuesday, no, merge ASAP, but
one day a week take care of the orphans :P )
Btw, what's your opinion on "merging in master multiple times", or
"rebasing" (if there's just one dev in the branch)? (I prefer avoiding
polluting the git log with the "merging master..." )
Thanks to the great community, the flow of new ideas is amazing!
Best regards, Mark
On Tue, Sep 10, 2013 at 9:13 PM, David Ragazzi <[email protected]>wrote:
> Yeah. It's good.
>
> However isn't better we directly update the repo with these changes? if
> so, I will commit the affected files with these adjustments.
>
> An question I would ask is: how and when pull requests are evaluated. I
> see many open pull requests (of mine and others) but not (apparent)
> progress with them.
>
> Thanks in advance,
>
> David
>
>
> On 10 September 2013 15:09, Matthew Taylor <[email protected]> wrote:
>
>> Updated link after spelling fix:
>> https://github.com/numenta/nupic/wiki/Running-NuPIC-on-Windows
>> ---------
>> Matt Taylor
>> OS Community Flag-Bearer
>> Numenta
>>
>>
>> On Tue, Sep 10, 2013 at 11:05 AM, Matthew Taylor <[email protected]>
>> wrote:
>> > David, thank you. I created a wiki doc out of your text file:
>> >
>> > https://github.com/numenta/nupic/wiki/Runnin-NuPIC-on-Windows
>> >
>> > Can you please review it? I'm not sure if I transcribed it all properly.
>> > ---------
>> > Matt Taylor
>> > OS Community Flag-Bearer
>> > Numenta
>> >
>> >
>> > On Mon, Sep 9, 2013 at 7:14 PM, David Ragazzi <[email protected]>
>> wrote:
>> >> Hi everyone,
>> >>
>> >> As I said, in my tests with CMake, I also managed build Nupic on
>> Windows
>> >> using Visual Studio (but I got the same runtime errors occured on OSX
>> with
>> >> XCode).
>> >>
>> >> I attached some instructions on this message but unfortunatelly I cant
>> send
>> >> Windows native libraries ("external" folder with DLLs and LIBs) due to
>> gmail
>> >> blocker (I also dont know how pull an entire folder to github repo)
>> but I
>> >> can send by shared google drive folder.
>> >>
>> >> It would be interesting more help to conclude this task (ie. CMake
>> >> conversion) since now I will have to dedicate my spare time to my
>> >> dissertation.. :-(
>> >>
>> >> Best wishes, David
>> >>
>> >> _______________________________________________
>> >> nupic mailing list
>> >> [email protected]
>> >> http://lists.numenta.org/mailman/listinfo/nupic_lists.numenta.org
>> >>
>>
>> _______________________________________________
>> nupic mailing list
>> [email protected]
>> http://lists.numenta.org/mailman/listinfo/nupic_lists.numenta.org
>>
>
>
> _______________________________________________
> nupic mailing list
> [email protected]
> http://lists.numenta.org/mailman/listinfo/nupic_lists.numenta.org
>
>
--
Marek Otahal :o)
_______________________________________________
nupic mailing list
[email protected]
http://lists.numenta.org/mailman/listinfo/nupic_lists.numenta.org
