[apparently the list didn't get the message, probably because it exceeds the 40kb threshold, so here it is in all its glory with my reply]
On Mon, 3 Sep 2018 at 14:32, Gabriele TAORMINA <[email protected]> wrote: > > Dear Daniele, > > > "I fixed a few issues, and pushed your changes (amended) to this > > temporary branch: https://github.com/zykh/nut/tree/issue-441+legrand > > Let me know if I misunderstood anything..." > > Thank you for the creation of the branch, I tried to submit some changes > according to your email (I never used GitHub before, please can you check if > I made it correctly?) Thanks for taking care of those issues (I added a quick review on GitHub). Now, scroll till the end of the mail... there's another question for you... > > > - usbhid-ups --> we added legrand-hid subdriver to extend the support to > > > our HID Devices (Keor SP and Keor PDU, following your dev guide) > > > > What are the exact models supported? I ask because we need to a) > > update the HCL and b) write (if possible/reasonable) a more precise > > comment alongside the USB_DEVICE() macro so that the VID:PID combo is > > propagated by our scripts with it. > > Also, is 'Keor PDU' just a commercial name, or it is indeed a power > > distribution unit? In case, we should signal that in 'device.type'. > > > > Now, just a few questions on the mapping: > > 1. Are the following items read-only? > > And do they change from time to time and need to be polled, or once > > retrieved they remain the same (i.e. they are static)? > > - input.transfer.low / UPS.Input.LowVoltageTransfer > > - input.transfer.high / UPS.Input.HighVoltageTransfer > > - input.transfer.low / UPS.PowerConverter.Output.LowVoltageTransfer > > - input.transfer.high / UPS.PowerConverter.Output.HighVoltageTransfer > > - battery.charge.warning / UPS.PowerSummary.WarningCapacityLimit > > - battery.charge.low / UPS.PowerSummary.RemainingCapacityLimit > > 2. Do the following ones return punctual data, or only the nominal > > value? If the latter, do they change, or they are static? > > - ups.realpower / UPS.Output.ConfigActivePower > > - ups.realpower / UPS.Flow.ConfigApparentPower > > 3. Are the following ones static? > > - input.voltage.nominal / UPS.Input.ConfigVoltage > > - input.voltage.nominal / UPS.Flow.ConfigVoltage > > - battery.voltage.nominal / UPS.PowerSummary.ConfigVoltage > > - battery.voltage.nominal / UPS.BatterySystem.Battery.ConfigVoltage > > 4. What's the reason for not using DEFAULT_OFFDELAY and > > DEFAULT_ONDELAY in the 'dfl' field of the load.off.delay and > > load.on.delay instant commands? > > Keor PDU is a commercial name for a Rack UPS, in the USB_DEVICE() macro I > tried to add a small description, I don't know if it's enough for you, what > kind of comment would you like? > > Regarding nutdrv_qx the only VID:PID combo is for one family: "Legrand Daker > DK+ 1kVA / 2kVA / 3kVA / 5kVA / 6kVA / 10kVA". This could be the description. > The items were Static, so I changed the file accordingly, i also added the > DEFAULT_ONDELAY and DEFAULT_OFFDELAY. Probably i forgot it in a first time! > These are the changes related to questions Nr. 1,2,3,4 of your previous email. > Here's the link of the pull request: > https://github.com/zykh/nut/pull/1/commits/4fe226b820128018e5089408f87b76c3345ff5e2 > > Regarding the exact models supported i checked the driver.list.in and updated > it with all the models: > https://github.com/zykh/nut/pull/3/commits/82dd085b4be23bb19d8477078ae9d3b8cc213130 > > > > - metasys --> this driver should be replaced (if possible) with the new > > > one we made called "Legrand_megawhad". This driver was for MetaSystem > > > UPSs, but this company has been acquired by Legrand, so we prefer to > > > replace the old driver with the new one, even because we solved some > > > issue and added new models (Compatibility: Megaline and Whad / Whad HE > > > Series) > > > > Name change: I don't think it will happen... I see your point, but I > > think that, at least for now, this will only annoy existing users > > (and, for reference, we still have drivers with 'mge' in their name, > > even though MGE Office Protection Systems has been part of Eaton since > > circa 2007, with, as far as I can remember, their products no longer > > branded as MGE). > > Maybe, we will reconsider this in future, if we rewrite the driver > > from scratch, or if we decide to rename all the drivers with a leading > > 'nutdrv_'... > > > > I extrapolated the (non-cosmetic) changes you made and applied them to > > the metasys driver, apart from the removal of the devices with an 'id > > code' < 14. > > Speaking of that, since you removed them: do they support the command > > you added (battery SOC, #8)? If not, we should make it optional. > > Regarding the Battery SOC Data in Metasys driver, no, it's not supported from > ID < 14. I mean that this UPS came out with the possibility to read SOC, but > this function needs to be enabled with some commands sent through serial > terminal. Furthermore, this UPS was produced ca. 15 Years ago, so we prefer > to not include it in the driver.list. > Battery SOC with all the other models works perfectly. > > > For our HCL: were those new devices you added also branded as Meta System? > > Whad / Megaline / Whad CAB / Whad HE are branded Legrand > DHEA is branded MetaSystem > > > > - nutdrv_qx --> we added our VID:PID to Krauler subdriver (together with > > > the patch you sent me last time) > > Here, too, what are the names of the supported devices? > > "Legrand Daker DK+ 1kVA / 2kVA / 3kVA / 5kVA / 6kVA / 10kVA" > > > > I also attached the Megaline / Whad UPSs communication protocol as > > > requested. > > Thanks, I added it to our protocol library. > > > > Just a question. > > The protocol only lists the devices with an 'id code' >= 11 and <= 28: > > what about the other ones? i.e.: > > - the ones already supported by the metasys driver: id < 11, > > - the other ones you added to the legrand_megawhad driver: 31, 32, 33. > > Regarding the ones already supported (ID < 11), they are obsolete (as written > produced more than 15 years ago). Do you happen to have a document describing the protocol used by them? Even an old one will do. > The ones i added (31, 32, 33) are the HE (High Efficiency) Models, we have to > update the protocol we sent you with these new models. > > For any question i'm here, thanks again for all your support! > > Best Regards, > Gabriele Taormina > UPS Strategic Business Unit > Field Application Engineer > Phone: +39 0522/207046 > Fax: +39 0522/207005 > Address: Via Rodano 1 - Reggio Emilia - 42124 - Italy > Email: [email protected] > Website: www.ups.legrand.com > Website: www.legrand.com _______________________________________________ Nut-upsdev mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev
