Citeren Richard Gregory <[email protected]>:
Attached is a patch against nut-2.4.1 that adds a driver for the ESP2
protocol, as used by the serial port found on the Liebert GXT2.
Thanks for this driver. We really appreciate this. A couple of remarks:
1) Don't patch Makefile.in files (these will be generated by autoconf)
2) Have a look at the developer documentation, especially
- docs/developers.txt ('Portability', 'Indenting', 'Spaghetti')
- docs/new-drivers.txt
The dstate_setinfo() function takes a formatted string (there is no
need for snprintf() here).
Especially for experimental drivers, use lots of debugging. If people
attempt to add other models and get unexpected results, we want to
know what is happening. The upsdebugx() and upsdebug_with_errno()
functions are your friend.
Try to cut down on casting of variables.
Best regards, Arjen
--
Please keep list traffic on the list
_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
