On Mon, 15 Feb 2010, Arjen de Korte wrote: [...] > I'm also not convinced that we really need/can use this in the first place. At > present, some drivers seem to print a message about the subdriver used here. > In case of multiple subdrivers, we would first have to select the right > subdriver and then the right subdrv_info element from the upsdrv_info. Since > there is no fixed relation between the two (subdriver used and information > about it in upsdrv_info), this is almost guaranteed to result in mismatches. > I'd prefer to use the dstate_set/getinfo method for storing and retrieving > this info. > > Short of the above, I think the other warnings should be resolved now. Could > you try to compile the latest version again on Solaris?
Much improvement. It went from 151 warnings to 57 warnings. Of those, all but 5 were the "too many struct/union initializers" warnings. What is left are these. "/opt/src/utils/nut-2.4.1-r2349/drivers/upscode2.c", line 138: warning: integer overflow detected: op "<<" "/opt/src/utils/nut-2.4.1-r2349/drivers/upscode2.c", line 138: warning: initializer does not fit or is out of range: -2147483648 "/opt/src/utils/nut-2.4.1-r2349/drivers/upscode2.c", line 540: warning: integer overflow detected: op "<<" "/opt/src/utils/nut-2.4.1-r2349/drivers/upscode2.c", line 709: warning: integer overflow detected: op "<<" "/opt/src/utils/nut-2.4.1-r2349/drivers/upscode2.c", line 713: warning: integer overflow detected: op "<<" > > Best regards, Arjen > -- Tim Rice Multitalents (707) 887-1469 [email protected] _______________________________________________ Nut-upsdev mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
