On mer., 2010-11-03 at 16:44 +0100, Arjen de Korte wrote: > Citeren Frederic BOHE <[email protected]>: > > > +#ifdef WIN32 > > + int noservice_flag = 0; > > + HANDLE svc_stop = NULL; > > + SERVICE_STATUS SvcStatus; > > + SERVICE_STATUS_HANDLE SvcStatusHandle; > > +#endif > > As far as I can tell, the SvcStatus and SvcStatusHanle variables are > only used in conjunction within this module. In that case, consider > not to export them in common.h and declare them static in common.c. > This keeps the interface clean and will also prevent other modules > messing with them behind your back. >
Currently, they are used in upsd.c too. But this is code that will need factorization too. After that, I will remove the extern variables from common.h regards Fred > Best regards, Arjen -------------------------------------------------------------------------- _______________________________________________ Nut-upsdev mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
