On 12-03-09 00:21, Greg A. Woods wrote:
I had independently made a similar change to the apcsmart driver to keep
it from failing when tcgetattr() reported some irrelevant differences in
the port settings. What's actually in the patch now is my merge of the
change from upstream which is basically just an "improved" log message.
The error from the past was a reason of too hasty zeroing, but after the
earlier commit, noone really commented on the issue. The flags /should/
match now. Would be good to test if they still don't.
I've also added some suggested coding improvements which I think will
make things easier to maintain down the line, notably using clear syntax
that's easy to modify safely for defining bit flag value macros, as well
Personally I prefer 0x approach, though I don't really care that much =)
Some ornamental changes (short help summary, etc.) I think go beyond
80th column now. I'll have to check this.
I'll check the actual changes carefully later. Thanks !
_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
