Hello everybody, I'm working on the "Use difftime for time comparison" bug (#313634). Charles directed me to the other one "Use monotonic clock for monitoring" attended to by Baruch; I believe that's very good idea, however I'd use a bit more encapsulated & general approach: 1/ I'd create an opaque timer type and its get/set/cmp/inc/dec etc interface under common 2/ implementation of the interface would use the monotonic clock if available (the clock_*time on Linux, potentially other monotonic clock impl. on other systems) and time_t as a fallback 3/ when implemented, use of the timer shall be spread throughout the code, replacing direct use of time_t What do you think? I'm also a bit reluptant to do such a change in scope of the bugfix; I'd create a new feature req. for that, OK? Any comments/ suggestions welcome, Regards, Vaclav
P.S: already managed to post this from another address by mistake, so please just discard the previous e-mail (or this one, depending on which you've read). -- Václav Krpec Software Developer Network UPS Tools project Eaton Opensource Team Eaton European Innovation Center ----------------------------- Eaton Elektrotechnika s.r.o. ~ S�dlo spolecnosti, jak je zaps�no v rejstr�ku: Kom�rovsk� 2406, Praha 9 - Horn� Pocernice, 193 00, Cesk� Republika ~ Jm�no, m�sto, kde byla spolecnost zaregistrov�na: Praha ~ Identifikacn� c�slo (ICO): 498 11 894 ----------------------------- _______________________________________________ Nut-upsdev mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
