2012/11/19 Elio Parisi <[email protected]> > Hi Arnaud, hi developers,**** > > ** >
Hi Elio and Massimo, > attach there is the patch for riello drivers.**** > > ** ** > > Can you tell me if there is other to change in order to accomplish your > rules and**** > > if the steps I have followed to create the patch are all rights?**** > > ** > thanks for your efforts, and congratulations: your drivers are now part of the NUT mainline: http://trac.networkupstools.org/projects/nut/changeset/3784 Note that I've had to fix a few things: - missing references to the new manpages in docs/man/Makefile.am: your manpages were not generated - missing reference to riello_usb in tools/nut-usbinfo.pl: it's needed to generated udev files, to set device permissions on Linux - out-of-date call to is_usb_device_supported(): the function prototype has changed in Subversion r3721 (2012-09-10) - I improved the USB_DEVICE declaration in riello_usb.c: I've added a define for Riello, and replaced the comment (Agiler) with something more suitable. These comments are used in various places, like udev files. - I've fixed some remaining c++ style comments (riello.c) - I've removed extraneous spaces, tabs and some samples of code that were not useful anymore - I've condensed entries in the driver.list As a side note, it's nice to see that Massimo participated, as manpage author ;) There are still some things that I would appreciate you fix (easier for maintenance), such as: - english variables names for: zapisuj, buf_ptr_spracuj_port, cakaj_data, ... - english functions name for: riello_koniec(), riello_prislo_nak(), riello_spracuj_port() I would also like to see some evidences of working devices, and some details on the testing you've done with these drivers. Sample upsc outputs would be also appreciated for the Devices Dumps Library<http://www.networkupstools.org/devdumps/> . Finally, please subscribe to the NUT users mailing list for supporting Riello users: http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsuser Thanks for your contribution. cheers, Arnaud -- NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.fr
_______________________________________________ Nut-upsdev mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
