ajiskrishnan: Please subscribe to nut-upsdev, and continue the discussion there: http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
On Dec 19, 2012, at 9:00 AM, ajiskrishnan wrote: > Adding pace.c in /driver - pace.c has a few variable names that need to be discussed, and the descriptions are copy-and-pasted from one another. - Please note the indentation style: http://www.networkupstools.org/docs/developer-guide.chunked/ar01s03.html#_coding_style - printf() is not to be used for debugging messages - there are functions which take a log severity level. - It would be a good idea to log a message in upsdrv_shutdown() saying that shutdown is not supported. > Adding the modified /driver/Makefile.in and Makefile.am Are the modifications essentially based on an older release of NUT? There really should only be one modification to driver/Makefile.am that adds your driver to the serial driver list. > Adding the configuration files in /conf We are not merging your personal configuration files. We will, however, need a man page for this driver, and that's a good place for you to document any suggested settings (such as the interesting use of /dev/ptmx). > You can merge this Pull Request by running: > > git pull https://github.com/ajiskrishnan/nut PACEprotocol > Or view, comment on, or merge it at: > > https://github.com/clepple/nut/pull/4 > > Commit Summary > > • Adding my pace.c implementation > • all my other configuration files for PACE > • misplaced the Makefiles > File Changes > > • M Makefile.am (357) > • A Makefile.in (1534) > • A conf/ups.conf (3) > • A conf/upsd.conf (16) > • A conf/upsd.users (13) > • A conf/upsmon.conf (301) > • M drivers/Makefile.am (22) > • A drivers/Makefile.in (1534) > • A drivers/pace.c (280) > Patch Links > > • https://github.com/clepple/nut/pull/4.patch > • https://github.com/clepple/nut/pull/4.diff -- Charles Lepple clepple@gmail _______________________________________________ Nut-upsdev mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
