On 09/07/2014 03:46, Charles Lepple wrote:
On Jul 8, 2014, at 3:29 AM, Giuseppe Corbelli 
<[email protected]> wrote:

Seems that on x64 architectures NULL is not #defined in <stddef.h>
the attached patch #includes <stdio.h> in AC_CHECK_DECLS. Tested on an ubuntu 
12.10 x64, seems to solve the issue.

I am a little confused as to how you are testing this :-)

Developed and tested on a Debian x86, got hold of an Ubuntu x64 to see what was going wrong, but I don't have the UPS on x64 machines.

The driver still wouldn't compile on Ubuntu 14.04 with libi2c-dev. The
"#if  HAVE_LINUX_I2C_DEV_H" won't be satisfied until after config.h is included
(typically by main.h). Since the driver won't even be compiled if
WITH_LINUX_I2C is not defined, I took out the #if wrapper.

My bad.

Also, since the intermediate commits aren't terribly useful, I'll collapse
the asem_i2c_take2 branch into a single commit before merging to master. Here
is the branch as it stands:

https://github.com/networkupstools/nut/compare/asem_i2c_take2

Looks fine to me.

--
            Giuseppe Corbelli
WASP Software Engineer, Copan Italia S.p.A
Phone: +390303666318  Fax: +390302659932
E-mail: [email protected]

_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev

Reply via email to