Doug Cutting (JIRA) wrote:
[
http://issues.apache.org/jira/browse/NUTCH-54?page=comments#action_65763
]

Doug Cutting commented on NUTCH-54: -----------------------------------

A few comments:

1. Changing fetcher.threads.per.host makes the fetcher impolite,
since it will no correctly obey fetcher.server.delay.

Right, this was not supposed to go into the patch - in the final version I'll keep the original values.

2. Many of your new files use CRLF rather than LF.

Will be fixed before commiting.


3. Some comments seem to have been removed from src/plugin/build.xml.

As above.


Other than that, this looks great!

Thanks. I'll clean up the remaining issues, and start committing in ca. 24 hours from now.

--
Best regards,
Andrzej Bialecki
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com



Reply via email to