Sami Siren wrote:
Andrzej Bialecki (JIRA) wrote:
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12364544
]
Andrzej Bialecki commented on NUTCH-169:
-----------------------------------------
This patch looks good! If there are no further objections, I'll test
it and commit it within the next 12 hours.
I quess I am a bit late with this...
The goal of these changes is very good but I don't like the idea of
duplicating identical code (implementing the interface NutchConfigure)
instead of inheritance (extending NutchConfigured) in so many places.
I actually pointed this out. The authors claimed that if we extended
NutchConfigured, in quite a few cases the setConf/getConf methods would
have to be overridden anyway to implement some special behavior, and in
cases where it was not necessary it was still better to do it to be
consistent (i.e. avoid a situation where some plugins implement
NutchConfigurable, and other plugins of the same type extend
NutchConfigured). For these reasons I decided to put it as it is for now.
At the time of split into Hadoop/Nutch we can revisit this issue.
--
Best regards,
Andrzej Bialecki <><
___. ___ ___ ___ _ _ __________________________________
[__ || __|__/|__||\/| Information Retrieval, Semantic Web
___|||__|| \| || | Embedded Unix, System Integration
http://www.sigram.com Contact: info at sigram dot com
