Jérôme Charron wrote:
Hi all,

I just notice an inconsistency when there is a parsing failure :

1. The Fetcher return an empty ParseImpl instance (it contains no metadata,
especially SEGMENT_NAME_KEY and SIGNATURE_KEY)
2. Then, the Indexer tries to add the fields segment and digest from the
metadata keys (SEGMENT_NAME_KEY and SIGNATURE_KEY) to the document.
Unforunately these values are null, a NPE is thrown and the process failed.


Is this happening with the latest code? I thought I fixed this, both in Fetcher and ParseSegment I check that these values are put in Parse metadata...

My question is : what behaviour is expected in such case?
1. Fetcher must add the SEGMENT_NAME and SIGNATURE metadata in empty
ParseImpl?
2. The Indexer must ignore documents without SEGMENT_NAME and SIGNATURE?
3. Both?

My feeling is 3, but I prefer that we discuss this point before
committing...

I thought it already does both things - it should do both.

--
Best regards,
Andrzej Bialecki     <><
___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com


Reply via email to