[ http://issues.apache.org/jira/browse/NUTCH-309?page=comments#action_12418396 ]
Dawid Weiss commented on NUTCH-309: ----------------------------------- Painful job, Jerome, but in most cases (non-critical loops) the gain will not be significant and proliferating if statements makes the code harder to read. Wrapping logging statements with code guards is a perfect aspect -- I'm sure it'd be possible to postprocess the binaries and do it automatically (with AspectJ or even a simple implementation of an observer in asmlib). Just a thought. > Uses commons logging Code Guards > -------------------------------- > > Key: NUTCH-309 > URL: http://issues.apache.org/jira/browse/NUTCH-309 > Project: Nutch > Type: Improvement > Versions: 0.8-dev > Reporter: Jerome Charron > Assignee: Jerome Charron > Priority: Minor > Fix For: 0.8-dev > > "Code guards are typically used to guard code that only needs to execute in > support of logging, that otherwise introduces undesirable runtime overhead in > the general case (logging disabled). Examples are multiple parameters, or > expressions (e.g. string + " more") for parameters. Use the guard methods of > the form log.is<Priority>() to verify that logging should be performed, > before incurring the overhead of the logging method call. Yes, the logging > methods will perform the same check, but only after resolving parameters." > (description extracted from > http://jakarta.apache.org/commons/logging/guide.html#Code_Guards) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
