[ http://issues.apache.org/jira/browse/NUTCH-309?page=all ] Doug Cutting reopened NUTCH-309: --------------------------------
I am re-opening this issue, as the guards were added in far too many places. Jerome, can you please fix these so that guards are only added when (a) the log level is DEBUG or TRACE, (b) it occurs in performance-critical code, and (c) the logged string is not constant. > Uses commons logging Code Guards > -------------------------------- > > Key: NUTCH-309 > URL: http://issues.apache.org/jira/browse/NUTCH-309 > Project: Nutch > Type: Improvement > Versions: 0.8-dev > Reporter: Jerome Charron > Assignee: Jerome Charron > Priority: Minor > Fix For: 0.8-dev > > "Code guards are typically used to guard code that only needs to execute in > support of logging, that otherwise introduces undesirable runtime overhead in > the general case (logging disabled). Examples are multiple parameters, or > expressions (e.g. string + " more") for parameters. Use the guard methods of > the form log.is<Priority>() to verify that logging should be performed, > before incurring the overhead of the logging method call. Yes, the logging > methods will perform the same check, but only after resolving parameters." > (description extracted from > http://jakarta.apache.org/commons/logging/guide.html#Code_Guards) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
