On 8/8/07, Marcin Okraszewski <[EMAIL PROTECTED]> wrote: > Hello Nutch Developers, > On May 22 I have contributed two patches - NUTCH-487 and NUTCH-490. The next > release is probably coming soon. I would be really pleased if they are merged > by then I don't have to patch it. Is there any chance they will be merged > into source code? I can port them to current head, but so far nobody asked > for this.
NUTCH-487 is mostly a duplicate of NUTCH-369. I merged patches from both issues in NUTCH-25 since NUTCH-25 needs those patches to work correctly (and I gave you and Renaud Richardet credit in comments). As for NUTCH-490, I haven't taken an in-depth look at it, but I don't see the point of it. Why not just use HtmlParseFilters since you have access to the DOM object? What advantage do neko filters have? Also, having an extension point for a library possibly used by a possibly used plugin looks really really wrong from a design point. > > I would also like to point your attention to one point. It is already two and > half month since I have added the patches. There is not even a single comment > on this. This is really discouraging for me, as a contributor. I know that > merging patches is not the thing that developers love to do, but you are the > only one who can do it. Of course I don't mean you should thank to every > contribution, but take it into account. Having someone's work being ignored, > and it looks like this for me, really discourages from further work. > Reviewing it and saying you won't merge it because something would be much > better than leaving it without a single comment. This may reduce your active > community. > > Think of this. > > Best regards, > Marcin Okraszewski > -- Doğacan Güney
