[
https://issues.apache.org/jira/browse/NUTCH-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653844#action_12653844
]
Todd Lipcon commented on NUTCH-669:
-----------------------------------
Agreed on all fronts.
I spent several hours yesterday refactoring/rewriting Fetcher2 to be a little
cleaner . One of the changes was to factor out the queueing policies into a new
class and replace the Thread-based model with one based on ExecutorServices. I
may also try to factor out the actual fetching into a new class as well.
I haven't gotten to testing the new version quite yet but hopefully should have
a patch available next week, and perhaps some intermediate commits available on
github this afternoon so people can see where I'm headed.
Is there a unit (or functional) testing infrastructure I can use somewhere to
test this?
-Todd
> Consolidate code for Fetcher and Fetcher2
> -----------------------------------------
>
> Key: NUTCH-669
> URL: https://issues.apache.org/jira/browse/NUTCH-669
> Project: Nutch
> Issue Type: Improvement
> Components: fetcher
> Affects Versions: 0.9.0
> Reporter: Todd Lipcon
> Priority: Minor
>
> I'd like to consolidate a lot of the common code between Fetcher and
> Fetcher2.java.
> It seems to me like there are the following differences:
> - Fetcher relies on the Protocol to obey robots.txt and crawl delay
> settings whereas Fetcher2 implements them itself
> - Fetcher2 uses a different queueing model (queue per crawl host) to
> accomplish the per-host limiting without making the Protocol do it.
> I've begun work on this but want to check with people on the following:
> - What reason is there for Fetcher existing at all since Fetcher2 seems to be
> a superset of functionality?
> - Is it on the road map to remove the robots/delay logic from the Http
> protocol and make Fetcher2's delegation of duties the standard?
> - Any other improvements wanted for Fetcher while I am in and around the code?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
